Skip to content

[NetAppFils] Anf 14807 net app files add quota limits to sdk 2021 06#24112

Merged
archerzz merged 2 commits intoAzure:mainfrom
audunn:ANF-14807-NetAppFiles-Add-QuotaLimits-To-SDK-2021-06
Sep 23, 2021
Merged

[NetAppFils] Anf 14807 net app files add quota limits to sdk 2021 06#24112
archerzz merged 2 commits intoAzure:mainfrom
audunn:ANF-14807-NetAppFiles-Add-QuotaLimits-To-SDK-2021-06

Conversation

@audunn
Copy link
Copy Markdown
Member

@audunn audunn commented Sep 20, 2021

Based on Azure/azure-rest-api-specs#15850
That adds things that where missing from 2021-06-01 api version.
The .net sDK has not been released based on 2021-06-01.

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ArthurMa1978 ArthurMa1978 added the Mgmt This issue is related to a management package. label Sep 22, 2021
Copy link
Copy Markdown
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@audunn Although those are small changes, we need to bump the version (1.15.0 or 1.14.1) because there are interface changes.

@fengzhou-msft
Copy link
Copy Markdown
Member

It looks like 1.14.0 is not released yet. Please confirm.

@audunn
Copy link
Copy Markdown
Member Author

audunn commented Sep 22, 2021

It looks like 1.14.0 is not released yet. Please confirm.

@fengzhou-msft yes it was not released due to the missing bits that we are adding here.

Copy link
Copy Markdown
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@archerzz archerzz merged commit 8b1e73c into Azure:main Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants