Skip to content

Storage mgmt track 2 library#23564

Merged
m-nash merged 44 commits intomainfrom
feature/mgmt-track2-storage
Sep 1, 2021
Merged

Storage mgmt track 2 library#23564
m-nash merged 44 commits intomainfrom
feature/mgmt-track2-storage

Conversation

@yukun-dong
Copy link
Copy Markdown
Contributor

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

* generate code and add storage account test

* add blob container test cases an record the test

* modify azure manager version and regenerate code

* regenerate code and add test cases

* regenerate code and add queue, table test cases

* regenerate code using remote spec and rerun tests

* add Properties and change Helpers position

* Add support for 'files' configuration (#23327)
…-storage

merge upstream/main to feature/mgmt-track2-storage
…-storage

merge upstream/main with feature/mgmt-track2-storage
…-storage

merge upstream/main to feature/mgmt-track2-storage
…-storage

merge upstream/main to feature/mgmt-track2-storage
@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Aug 26, 2021
yukun-dong and others added 23 commits August 30, 2021 13:51
…-storage

merge upstream/main to feature/mgmt-track2-storage
…-storage

merge upstream/main to feature/mgmgt-track2-storage
…-storage

merge upstream/main with feature/mgmt-track2-storage
…-storage

merge upstream/main to feature/mgmt-track2-storage
@m-nash m-nash merged commit 17f2893 into main Sep 1, 2021
@m-nash m-nash deleted the feature/mgmt-track2-storage branch September 1, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants