Skip to content

Make the accept session concurrency dynamic#23356

Merged
JoshLove-msft merged 2 commits intoAzure:mainfrom
JoshLove-msft:accept-session-concurrency
Aug 17, 2021
Merged

Make the accept session concurrency dynamic#23356
JoshLove-msft merged 2 commits intoAzure:mainfrom
JoshLove-msft:accept-session-concurrency

Conversation

@JoshLove-msft
Copy link
Copy Markdown
Member

@JoshLove-msft JoshLove-msft commented Aug 17, 2021

Porting still applicable changes from #23282

  • Accepting a session should respect the updated concurrency
  • Use CT when opening link
  • Set link level timeout

Filed #23333 to complete CT migration.

@JoshLove-msft JoshLove-msft requested a review from jsquire as a code owner August 17, 2021 04:00
@ghost ghost added the Service Bus label Aug 17, 2021
@JoshLove-msft JoshLove-msft requested a review from pakrym August 17, 2021 04:00
@JoshLove-msft
Copy link
Copy Markdown
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

catch (Exception ex)
when (ex is not TaskCanceledException ||
// If the user manually throws a TCE, then we should log it.
(!_sessionCancellationSource.IsCancellationRequested &&
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not needed because TCE thrown by user handler were already being logged within ProcessOneMessage

@JoshLove-msft
Copy link
Copy Markdown
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft JoshLove-msft merged commit 2271e49 into Azure:main Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants