Skip to content

Revert unconditional log attachment #23343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pakrym merged 1 commit into from
Aug 16, 2021
Merged

Revert unconditional log attachment #23343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions sdk/core/Azure.Core.TestFramework/src/RecordedTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
using Castle.DynamicProxy;
using NUnit.Framework;
using NUnit.Framework.Interfaces;
using NUnit.Framework.Internal;

namespace Azure.Core.TestFramework
{
Expand Down Expand Up @@ -80,6 +79,7 @@ public T InstrumentClientOptions<T>(T clientOptions, TestRecording recording = d
protected string GetSessionFilePath()
{
TestContext.TestAdapter testAdapter = TestContext.CurrentContext.Test;

string name = new string(testAdapter.Name.Select(c => s_invalidChars.Contains(c) ? '%' : c).ToArray());
string additionalParameterName = testAdapter.Properties.ContainsKey(ClientTestFixtureAttribute.RecordingDirectorySuffixKey) ?
testAdapter.Properties.Get(ClientTestFixtureAttribute.RecordingDirectorySuffixKey).ToString() :
Expand Down Expand Up @@ -153,13 +153,6 @@ public virtual void StartTestRecording()
[TearDown]
public virtual void StopTestRecording()
{
if (TestEnvironment.GlobalIsRunningInCI)
{
var tempFileName = Path.GetTempFileName() + ".txt";
File.WriteAllText(tempFileName, TestExecutionContext.CurrentContext.CurrentResult.Output);
TestContext.AddTestAttachment(tempFileName, "Test Output");
}

bool testPassed = TestContext.CurrentContext.Result.Outcome.Status == TestStatus.Passed;

if (ValidateClientInstrumentation && testPassed)
Expand Down