Handle relative urls in Location redirect header#23252
Merged
pakrym merged 1 commit intoAzure:mainfrom Aug 16, 2021
Merged
Conversation
ghost
added
the
Contributor
Author
|
/azp run net - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annelo-msft
reviewed
Aug 16, 2021
| System.Text.DecoderFallback.ExceptionFallback); | ||
| return decoder.GetString(rawBytes, 0, rawBytes.Length); | ||
| } | ||
| catch (ArgumentException) { } // Not actually Utf-8 |
Member
There was a problem hiding this comment.
Are you worried about swallowing this exception?
Contributor
Author
There was a problem hiding this comment.
Nope, we expect the GetString to throw if it fails to decode.
annelo-msft
approved these changes
Aug 16, 2021
Contributor
Author
|
/check-enforcer override |
pakrym
deleted the
pakrym/Handle-relative-urls-in-Location-redirect-header
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.