Skip to content

Public API spell check#23150

Merged
danieljurek merged 12 commits intomainfrom
djurek/spellcheck-public-api-opt-out
Aug 18, 2021
Merged

Public API spell check#23150
danieljurek merged 12 commits intomainfrom
djurek/spellcheck-public-api-opt-out

Conversation

@danieljurek
Copy link
Copy Markdown
Member

@danieljurek danieljurek commented Aug 6, 2021

  • Switch to opt-out
  • Opt out of services which have detected spelling errors

Opted out (has spelling errors in public api):

  • core -- Core is opted out because its CI run incorporates scanning of all public API surfaces which includes APIs that have spelling errors.
  • agrifood
  • communication
  • compute
  • containerregistry
  • cosmosdb
  • digitaltwins
  • dns
  • eventgrid
  • insights
  • machinelearningservices
  • modelsrepository
  • monitor
  • network
  • objectanchors
  • purview
  • remoterendering
  • sqlmanagement
  • synapse
  • videoanalyzer

Opted in (no change to ci.yml):

  • anomalydetector
  • appconfiguration
  • applicationinsights
  • attestation
  • batch
  • cognitivelanguage
  • cognitiveservices
  • confidentialledger
  • containerinstance
  • deviceupdate
  • eventhub
  • extensions
  • formrecognizer
  • graphrbac
  • hdinsight
  • identity
  • iot
  • keyvault
  • metricsadvisor
  • mixedreality
  • operationalinsights
  • personalizer
  • quantum
  • resourcemanager
  • resources
  • schemaregistry
  • search
  • servicebus
  • storage
  • tables
  • template
  • textanalytics
  • timeseriesinsights
  • translation
  • webpubsub

@maririos
Copy link
Copy Markdown
Member

maririos commented Aug 6, 2021

To keep track of the opted-out ones, could you make sure the list here is updated?

@danieljurek danieljurek force-pushed the djurek/spellcheck-public-api-opt-out branch from ece84a9 to 9a75e0c Compare August 6, 2021 19:03
@danieljurek
Copy link
Copy Markdown
Member Author

CI analyze has passed for this PR:

@danieljurek
Copy link
Copy Markdown
Member Author

Test builds from the latest round of changes. It's important that the Analyze step passes as it is the one evaluating the spelling and relevant to the changes. Some pipelines have unrelated failures in the Build step.

This can merge once the aggregate-reports build finishes successfully.

@danieljurek danieljurek enabled auto-merge (squash) August 18, 2021 16:53
@danieljurek danieljurek merged commit 3d9ee7a into main Aug 18, 2021
@danieljurek danieljurek deleted the djurek/spellcheck-public-api-opt-out branch August 18, 2021 17:57
@weshaggard
Copy link
Copy Markdown
Member

@danieljurek I assume you still need to go through the issues and update them with the new instructions. At least the one I randomly checked #23172 still had the old instructions.

@danieljurek
Copy link
Copy Markdown
Member Author

Instructions are updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants