test-resources.json and test changes by orenmichaely · Pull Request #23117 · Azure/azure-sdk-for-net

orenmichaely · 2021-08-04T22:20:10Z

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

Please open PR in Draft mode if it is:
- Work in progress or not intended to be merged.
- Encountering multiple pipeline failures and working on fixes.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

Include updated management metadata.
Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:
- Do not modify any code in generated folders.
- Do not selectively include/remove generated files in the PR.
- Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
  Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.
Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
```
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
```

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

Mohit-Chakraborty

Please verify the SDK behavior with the changes.

orenmichaely · 2021-08-04T23:29:22Z

/azp run net - personalizer - tests

azure-pipelines · 2021-08-04T23:29:34Z

Azure Pipelines successfully started running 1 pipeline(s).

orenmichaely · 2021-08-05T02:48:11Z

/azp run personalizer - net

azure-pipelines · 2021-08-05T02:48:17Z

No pipelines are associated with this pull request.

orenmichaely · 2021-08-05T18:54:03Z

/azp run net - personalizer - tests

azure-pipelines · 2021-08-05T18:54:16Z

Azure Pipelines successfully started running 1 pipeline(s).

orenmichaely · 2021-08-05T22:23:15Z

/azp run net - personalizer - tests

azure-pipelines · 2021-08-05T22:23:26Z

Azure Pipelines successfully started running 1 pipeline(s).

orenmichaely · 2021-08-06T15:02:57Z

/azp run net - personalizer - tests

azure-pipelines · 2021-08-06T15:03:10Z

Azure Pipelines successfully started running 1 pipeline(s).

orenmichaely · 2021-08-06T16:33:22Z

/azp run net - personalizer - tests

azure-pipelines · 2021-08-06T16:33:36Z

Azure Pipelines successfully started running 1 pipeline(s).

orenmichaely · 2021-08-06T17:11:54Z

/azp run net - personalizer - tests

azure-pipelines · 2021-08-06T17:12:08Z

Azure Pipelines successfully started running 1 pipeline(s).

orenmichaely · 2021-08-06T18:26:58Z

/azp run net - personalizer - tests

orenmichaely · 2021-08-09T00:03:12Z

/azp run net - personalizer - tests

azure-pipelines · 2021-08-09T00:04:17Z

Azure Pipelines successfully started running 1 pipeline(s).

orenmichaely · 2021-08-09T00:05:15Z

/azp run net - personalizer - tests

azure-pipelines · 2021-08-09T00:05:27Z

Azure Pipelines successfully started running 1 pipeline(s).

orenmichaely · 2021-08-09T14:00:12Z

/azp run net - personalizer - tests

azure-pipelines · 2021-08-09T14:00:49Z

Azure Pipelines successfully started running 1 pipeline(s).

orenmichaely · 2021-08-09T16:02:23Z

/azp run net - personalizer - tests

azure-pipelines · 2021-08-09T16:02:39Z

Azure Pipelines successfully started running 1 pipeline(s).

orenmichaely · 2021-08-09T20:18:19Z

/azp run net - personalizer - tests

azure-pipelines · 2021-08-09T20:18:31Z

Azure Pipelines successfully started running 1 pipeline(s).

heaths

Only reviewed the test resources scripts. Mainly, don't log out of the CLI you never logged into. That was only for Key Vault because the Az cmdlets don't support Managed HSMs in a deleted state yet while the azure CLI does.

sdk/personalizer/remove-test-resources-post.ps1

sdk/personalizer/test-resources.json

Changes were made but I'm not reviewing the whole PR. Better a code owner for the rest of the source changes do that.

Mohit-Chakraborty

Blocking till we are ready to merge.

orenmichaely · 2021-08-17T17:18:31Z

/azp run net - personalizer - tests

azure-pipelines · 2021-08-17T17:18:44Z

Azure Pipelines successfully started running 1 pipeline(s).

orenmichaely · 2021-08-17T21:16:40Z

/azp run net - personalizer - tests

azure-pipelines · 2021-08-17T21:16:51Z

Azure Pipelines successfully started running 1 pipeline(s).

pakrym · 2021-09-01T23:47:26Z

sdk/personalizer/Azure.AI.Personalizer/tests/Infrastructure/PersonalizerTestBase.cs

+            {
+                properties.IsAutoOptimizationEnabled = false;
+                await adminClient.UpdatePersonalizerPropertiesAsync(properties);
+                await Task.Delay(30000);


This is not ideal. It makes the playback test take a minute.

pakrym · 2021-09-01T23:48:01Z

sdk/personalizer/Azure.AI.Personalizer/tests/Personalizer/ConfigurationsTests.cs

+            Assert.AreEqual(properties.ModelExportFrequency, result.ModelExportFrequency);
+            Assert.AreEqual(properties.RewardAggregation, result.RewardAggregation);
+            Assert.AreEqual(properties.RewardWaitTime, result.RewardWaitTime);
+            if (Environment.GetEnvironmentVariable("AZURE_TEST_MODE") == "Record")


There is a Mode property on the base type

test-resources.json and test changes

29d6f7d

orenmichaely requested review from Mohit-Chakraborty and tyclintw as code owners August 4, 2021 22:20

exported api

ce3403c

orenmichaely requested review from KrzysztofCwalina and tg-msft as code owners August 4, 2021 22:32

Mohit-Chakraborty approved these changes Aug 4, 2021

View reviewed changes

ormichae added 2 commits August 4, 2021 16:10

rounded float

bb518e9

ignore body

dfe5f35

added timeouts in test

1a4095f

consoladated tests

b423f72

changes region for resources

8fc7ea4

ormichae added 2 commits August 6, 2021 10:07

moved resources to east us

ba90642

added delay between update policy and get

53f2deb

merged all multislot tests

d52d83c

moved test tesources to east us

98cd5f1

movel resource to canary

b865344

changed resource location to centralus

763399e

ormichae added 2 commits August 11, 2021 13:39

added remove test resources post script

b894b18

added line to eof

03ce9c1

heaths previously requested changes Aug 11, 2021

View reviewed changes

sdk/personalizer/remove-test-resources-post.ps1 Outdated Show resolved Hide resolved

sdk/personalizer/test-resources.json Show resolved Hide resolved

pr comments

da1a35a

orenmichaely closed this Aug 11, 2021

orenmichaely reopened this Aug 11, 2021

Mohit-Chakraborty suggested changes Aug 12, 2021

View reviewed changes

changed resource deployment to eastus2euap

4b47a69

Mohit-Chakraborty approved these changes Aug 18, 2021

View reviewed changes

Mohit-Chakraborty merged commit a2e976c into Azure:main Aug 18, 2021

pakrym reviewed Sep 1, 2021

View reviewed changes

Conversation

orenmichaely commented Aug 4, 2021

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

SDK Generation Guidelines

Additional management plane SDK specific contribution checklist:

Management plane SDK Troubleshooting

Old outstanding PR cleanup

Uh oh!

Mohit-Chakraborty left a comment

Choose a reason for hiding this comment

Uh oh!

orenmichaely commented Aug 4, 2021

Uh oh!

azure-pipelines bot commented Aug 4, 2021

Uh oh!

orenmichaely commented Aug 5, 2021

Uh oh!

azure-pipelines bot commented Aug 5, 2021

Uh oh!

orenmichaely commented Aug 5, 2021

Uh oh!

azure-pipelines bot commented Aug 5, 2021

Uh oh!

orenmichaely commented Aug 5, 2021

Uh oh!

azure-pipelines bot commented Aug 5, 2021

Uh oh!

orenmichaely commented Aug 6, 2021

Uh oh!

azure-pipelines bot commented Aug 6, 2021

Uh oh!

orenmichaely commented Aug 6, 2021

Uh oh!

azure-pipelines bot commented Aug 6, 2021

Uh oh!

orenmichaely commented Aug 6, 2021

Uh oh!

azure-pipelines bot commented Aug 6, 2021

Uh oh!

orenmichaely commented Aug 6, 2021

Uh oh!

orenmichaely commented Aug 9, 2021

Uh oh!

azure-pipelines bot commented Aug 9, 2021

Uh oh!

orenmichaely commented Aug 9, 2021

Uh oh!

azure-pipelines bot commented Aug 9, 2021

Uh oh!

orenmichaely commented Aug 9, 2021

Uh oh!

azure-pipelines bot commented Aug 9, 2021

Uh oh!

orenmichaely commented Aug 9, 2021

Uh oh!

azure-pipelines bot commented Aug 9, 2021

Uh oh!

orenmichaely commented Aug 9, 2021

Uh oh!

azure-pipelines bot commented Aug 9, 2021

Uh oh!

heaths left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Mohit-Chakraborty left a comment

Choose a reason for hiding this comment

Uh oh!

orenmichaely commented Aug 17, 2021

Uh oh!

azure-pipelines bot commented Aug 17, 2021

Uh oh!

orenmichaely commented Aug 17, 2021

Uh oh!

azure-pipelines bot commented Aug 17, 2021

Uh oh!

pakrym Sep 1, 2021