StaticTokenCredential

[christothes]

#19404
#21940
#19443

[pakrym]

What about a static method? TokenCredential.Create(string token)?

We did a similar thing with Page and AsyncPageable.

[christothes]

What about a static method? TokenCredential.Create(string token)?

We did a similar thing with Page and AsyncPageable.

Instead of a ctor?

[pakrym]

Instead of a ctor?

Instead of an additional class. TokenCredential.Create(string token) would return a TokenCredential

[christothes]

Instead of a ctor?

Instead of an additional class. TokenCredential.Create(string token) would return a TokenCredential

Interesting idea - but I'm not sure that I like having a generic TokenCredential that can't be identified specifically as a static token credential.

[pakrym]

not sure that I like having a generic TokenCredential that can't be identified specifically as a static token credential.

Why not?

[schaabs]

What about a static method? TokenCredential.Create(string token)?

I do like this from a design perspective, but honestly I'm not sold on adding the class or the static method. I think either lead users down a bad path because while simply using a static token seems like the path of least resistance, it will only work for a short period of time and the user needs to manage it's lifetime and scope properly which is not trivial. This is why we have be reluctant to add this class, and I think that a static method would exacerbate this problem as users could look at TokenCredential (which is abstract so no ctor) find this static method and assume that's what they are intended to use for authentication.

[schaabs]

Does the func need to return ValueTask? If not I wonder if Task<AccessToken> would be easier for users.

[christothes]

I wanted to keep it 1:1 with GetToken's signature, unless you feel strongly otherwise

[schaabs]

I don't feel strongly I just wanted to pose the question to others.