Skip to content

ADO 5883 - Adding scope support for ArmClient initialization #22897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allenjzhang merged 5 commits into from
Jul 28, 2021
Merged

ADO 5883 - Adding scope support for ArmClient initialization #22897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4aeacdf
Update to support scope
HarveyLink Jul 27, 2021
524c3e9
Revert "Update to support scope"
HarveyLink Jul 28, 2021
efa9617
Update in ArmClientOption
HarveyLink Jul 28, 2021
b625f8a
Merge branch 'main' into minghc/pipelinescope
HarveyLink Jul 28, 2021
6b3346c
Update Azure.ResourceManager.netstandard2.0.cs
HarveyLink Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/resourcemanager/Azure.ResourceManager/api/Azure.ResourceManager.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public sealed partial class ArmClientOptions : Azure.Core.ClientOptions
{
public ArmClientOptions() { }
public Azure.ResourceManager.ApiVersions ApiVersions { get { throw null; } }
public string Scope { get { throw null; } set { } }
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
public object GetOverrideObject<T>(System.Func<object> objectConstructor) { throw null; }
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/resourcemanager/Azure.ResourceManager/src/ArmClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public ArmClient(
Credential = credential;
BaseUri = baseUri ?? new Uri(DefaultUri);
ClientOptions = options?.Clone() ?? new ArmClientOptions();
Pipeline = ManagementPipelineBuilder.Build(Credential, BaseUri, options ?? ClientOptions);
Pipeline = ManagementPipelineBuilder.Build(Credential, options.Scope, options ?? ClientOptions);

_tenant = new TenantOperations(ClientOptions, Credential, BaseUri, Pipeline);
DefaultSubscription = string.IsNullOrWhiteSpace(defaultSubscriptionId)
Expand Down
5 changes: 5 additions & 0 deletions sdk/resourcemanager/Azure.ResourceManager/src/ArmClientOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ public sealed class ArmClientOptions : ClientOptions
/// </summary>
public ApiVersions ApiVersions { get; private set; }

/// <summary>
/// Gets the ApiVersions object
/// </summary>
public string Scope { get; set; } = "https://management.core.windows.net/.default";

/// <summary>
/// Initializes a new instance of the <see cref="ArmClientOptions"/> class.
/// </summary>
Expand Down