Skip to content

Fix for consistently failing tests #22756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annelo-msft merged 1 commit into from
Jul 20, 2021
Merged

Fix for consistently failing tests #22756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions ...ontainerregistry/Azure.Containers.ContainerRegistry/tests/ContainerRepositoryLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,15 +169,9 @@ public async Task CanGetManifestsWithCustomPageSize(bool anonymous)
AsyncPageable<ArtifactManifestProperties> artifacts = repository.GetManifestPropertiesCollectionAsync();
var pages = artifacts.AsPages(pageSizeHint: pageSize);

int pageCount = 0;
await foreach (var page in pages)
{
Assert.GreaterOrEqual(page.Values.Count, pageSize);
pageCount++;
}

// Assert
Assert.IsTrue(pageCount >= minExpectedPages);
int pageCount = await pages.CountAsync();
Assert.GreaterOrEqual(pageCount, minExpectedPages);
}

[RecordedTest]
Expand Down
2 changes: 1 addition & 1 deletion sdk/containerregistry/Azure.Containers.ContainerRegistry/tests/RegistryArtifactLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public async Task CanGetManifestListProperties()
// Assert
Assert.Contains(tag, properties.Tags.ToList());
Assert.AreEqual(_repositoryName, properties.RepositoryName);
Assert.GreaterOrEqual(helloWorldRelatedArtifacts, properties.RelatedArtifacts.Count);
Assert.GreaterOrEqual(properties.RelatedArtifacts.Count, helloWorldRelatedArtifacts);

Assert.IsTrue(properties.RelatedArtifacts.Any(
artifact =>
Expand Down