Skip to content

Conversation

@annelo-msft
Copy link
Member

Updates to fix failing nightly live tests.

  • The multi-architecture images we were pulling from DockerHub added new architectures. Because of this, I learned I had my greater than or equals to operator in the wrong direction :-/
  • Modifying the same resources at the same time from tests on different platforms was causing intermittent failures. I've updated all the tests that modify or delete an artifact to create a new independent artifact at the beginning of the test and clean it up at the end.

Fixes #21236

@annelo-msft annelo-msft marked this pull request as draft July 19, 2021 17:35
int maxLength = 25;
if (value.Length > maxLength)
{
value = value.Substring(0, maxLength);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: If a SubString ends up being needed, it'd be better to do that before replacing values.

@annelo-msft
Copy link
Member Author

Closing, given this approach doesn't work well with test recordings.

@annelo-msft annelo-msft closed this Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ACR] Address failing nightly tests

2 participants