-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[PostgreSQL] SDK upgrade for PostgreSQL Flexible Server GA API #22712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@DaeunYim Could you please post the link to the SwaggerPR? Thanks |
Azure/azure-rest-api-specs#14653 |
...t.Azure.Management.PostgreSQL/src/postgresqlflexibleservers/Generated/DatabasesOperations.cs
Show resolved
Hide resolved
...t.Azure.Management.PostgreSQL/src/postgresqlflexibleservers/Generated/DatabasesOperations.cs
Show resolved
Hide resolved
The Swagger doesn't have a "Breaking Change" label or "Approved Breaking Change" label added. |
This is brand new API version. We introduced a new API for this product. It's new. The previous flexible server SDK is based on preview API. |
|
Breaking changes are ok since this is new, but could the version be updated in the .csproj, AssemblyInfo, and AzSDK.RP.prop? Thanks |
|
@nisha-bhatia Sorry for getting back late.. Just updated the versions |
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new servicelabel and/or contact assigned reviewer.If the check fails at the
Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.