Skip to content

Use CurrentCulture for datetime parsing #22683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christothes merged 2 commits into from
Jul 16, 2021
Merged

Use CurrentCulture for datetime parsing #22683

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a29a66b
Use CurrentCulture for datetime parsing
christothes Jul 16, 2021
7f0b03d
Add test
christothes Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/identity/Azure.Identity/src/AzurePowerShellCredential.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ private static AccessToken DeserializeOutput(string output)
break;

case "ExpiresOn":
expiresOn = DateTimeOffset.Parse(e.Value, CultureInfo.InvariantCulture).ToUniversalTime();
expiresOn = DateTimeOffset.Parse(e.Value, CultureInfo.CurrentCulture).ToUniversalTime();

@jsquire jsquire Jul 16, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe include a test using the case from the linked bug?

@christothes christothes Jul 16, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

break;
}

Expand Down