Merged
Conversation
45a21ba to
67058c2
Compare
m-nash
requested changes
Jul 15, 2021
common/ManagementTestShared/Redesign/ManagementRecordedTestBase.cs
Outdated
Show resolved
Hide resolved
common/ManagementTestShared/Redesign/ManagementRecordedTestBase.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
Hey @m-nash I have resolved the comments, could you please take a look again? BTW the CI failure is due to some glitch of downloading, not issues in the code |
m-nash
approved these changes
Jul 19, 2021
pakrym
reviewed
Jul 19, 2021
| { | ||
| public MockTestEnvironment() : base() | ||
| { | ||
| Environment.SetEnvironmentVariable("SUBSCRIPTION_ID", "00000000-0000-0000-0000-000000000000"); |
Contributor
There was a problem hiding this comment.
Don't do this. This might break other tests that run in the same process after.
Contributor
There was a problem hiding this comment.
Override the property instead.
pakrym
reviewed
Jul 19, 2021
| public MockTestEnvironment() : base() | ||
| { | ||
| Environment.SetEnvironmentVariable("SUBSCRIPTION_ID", "00000000-0000-0000-0000-000000000000"); | ||
| Environment.SetEnvironmentVariable("RESOURCE_MANAGER_URL", MockEndPoint); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reopen of PR #22445
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new servicelabel and/or contact assigned reviewer.If the check fails at the
Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.