Add readme.md to all nuget packages#22543
Merged
pakrym merged 1 commit intoAzure:mainfrom Jul 19, 2021
Merged
Conversation
pakrym
requested review from
chidozieononiwu,
danieljurek,
mitchdenny and
weshaggard
as code owners
weshaggard
reviewed
Jul 8, 2021
| <OriginalReadmeMdPath>$([MSBuild]::NormalizeDirectory($(MSBuildProjectDirectory)/../))README.md</OriginalReadmeMdPath> | ||
| <ProcessedReadmeMdPath>$(IntermediateOutputPath)README.md</ProcessedReadmeMdPath> | ||
| <EnableNuGetReadmeMd Condition="'$(HasReleaseVersion)' == 'false' and Exists('$(OriginalReadmeMdPath)')">true</EnableNuGetReadmeMd> | ||
| <EnableNuGetReadmeMd Condition="'$(IsDesignTimeBuild)' == 'false' and Exists('$(OriginalReadmeMdPath)')">true</EnableNuGetReadmeMd> |
Member
There was a problem hiding this comment.
Shouldn't we keep both conditions?
Contributor
Author
There was a problem hiding this comment.
We had the HasReleaseVersion to only include README in previews, so removing it accomplishes having readme in GA packages as well.
weshaggard
approved these changes
Jul 8, 2021
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
One question but otherwise seems reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things seemed to have gone well this release.
The
IsDesignTimeBuildfixes #22098