Skip to content

Add some logging and add Retry attribute #22428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christothes merged 1 commit into from
Jul 3, 2021
Merged

Add some logging and add Retry attribute #22428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sdk/core/Azure.Core/tests/BearerTokenAuthenticationPolicyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,6 +729,7 @@ public async Task BearerTokenAuthenticationPolicy_BackgroundRefreshCancelledAndL
}

[Test]
[Retry(3)] //https://github.com/Azure/azure-sdk-for-net/issues/21005
public async Task BearerTokenAuthenticationPolicy_BackgroundRefreshFailsAndLogs()
{
var requestMre = new ManualResetEventSlim(true);
Expand All @@ -740,6 +741,7 @@ public async Task BearerTokenAuthenticationPolicy_BackgroundRefreshFailsAndLogs(
string msg = "fail to refresh";
var credential = new BearerTokenAuthenticationPolicyTests.TokenCredentialStub((r, c) =>
{
TestContext.WriteLine($"Start TokenCredentialStub: callCount: {callCount}");
if (callCount > 0)
{
throw new Exception(msg);
Expand All @@ -749,12 +751,14 @@ public async Task BearerTokenAuthenticationPolicy_BackgroundRefreshFailsAndLogs(
requestMre.Reset();
callCount++;

TestContext.WriteLine($"End TokenCredentialStub: callCount: {callCount}");
return new AccessToken(Guid.NewGuid().ToString(), expires.Dequeue());
},
IsAsync);

AzureEventSourceListener listener = new((args, text) =>
{
TestContext.WriteLine(text);
if (args.EventName == "BackgroundRefreshFailed" && text.Contains(msg))
{
logged = true;
Expand All @@ -768,7 +772,6 @@ public async Task BearerTokenAuthenticationPolicy_BackgroundRefreshFailsAndLogs(
responseMre.Reset();

Task requestTask = SendGetRequest(transport, policy, uri: new Uri("https://example.com/3/Refresh"));
// requestMre.Wait();

await SendGetRequest(transport, policy, uri: new Uri("https://example.com/2/AlmostExpired"));
await requestTask;
Expand Down