Skip to content

[MetricsAdvisor] Updated DataFeedSource constructors#22427

Merged
kinelski merged 3 commits intoAzure:camaiaor/ma-beta5from
kinelski:ma-sources
Jul 8, 2021
Merged

[MetricsAdvisor] Updated DataFeedSource constructors#22427
kinelski merged 3 commits intoAzure:camaiaor/ma-beta5from
kinelski:ma-sources

Conversation

@kinelski
Copy link
Copy Markdown
Contributor

@kinelski kinelski commented Jul 2, 2021

Adding/removing data source constructors based on what parameters are currently required by the service (fixes #21616).

@kinelski kinelski added the Client This issue is related to a non-management package label Jul 2, 2021
@kinelski kinelski requested a review from maririos July 2, 2021 21:57
@kinelski kinelski self-assigned this Jul 2, 2021
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not actually supported by the service. Other properties are required now. We'll possibly add this constructor back again as new types of credentials are added.

@check-enforcer
Copy link
Copy Markdown

check-enforcer Bot commented Jul 2, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@kinelski kinelski linked an issue Jul 5, 2021 that may be closed by this pull request
@kinelski kinelski removed the request for review from maririos July 7, 2021 02:27
@kinelski kinelski marked this pull request as draft July 7, 2021 02:27
@kinelski kinelski marked this pull request as ready for review July 7, 2021 23:49
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do u want to add a test for it? I think as is fine, but just in case u want to check query empty and the exception and etc...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tests for new ctors.

@kinelski kinelski force-pushed the camaiaor/ma-beta5 branch from a9fb5da to 91d1922 Compare July 8, 2021 20:51
@kinelski kinelski merged commit c010168 into Azure:camaiaor/ma-beta5 Jul 8, 2021
@kinelski kinelski deleted the ma-sources branch July 8, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue is related to a non-management package Cognitive - Metrics Advisor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MetricsAdvisor] Revisit required parameters in Data Feed Sources

2 participants