Remove autorest models with internal properties #22259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderSher
requested review from
AlexGhiondea,
JoshLove-msft,
Kishp01,
KrzysztofCwalina,
LarryOsterman,
ahamad-MS,
annelo-msft,
chidozieononiwu,
christothes,
danieljurek,
jfggdl,
kinelski,
maririos,
mitchdenny,
pakrym,
tg-msft and
weshaggard
as code owners
ghost
added
pakrym
approved these changes
Jun 28, 2021
annelo-msft
reviewed
Jun 28, 2021
Member
annelo-msft
left a comment
annelo-msft
left a comment
There was a problem hiding this comment.
For ACR, this is removing a model type that customers may still want to mock ... are there plans to replace the methods in model factory so they can be created with only the public properties?
Contributor
Author
|
@annelo-msft The problem is that we can't be sure that public properties are enough for the model to be fully initialized, so we can't simply supply default values for property types. |
…o RemoveInternalFields # Conflicts: # sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/Generated/MicrosoftAzureMetricsAdvisorRestAPIOpenAPIV2ModelFactory.cs
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Feb 3, 2023
Fix runningOperationIds data type (Azure#22259) * Fix runningOperationIds data type * Fix PR comments
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Feb 3, 2023
Fix runningOperationIds data type (Azure#22259) * Fix runningOperationIds data type * Fix PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.