[MetricsAdvisor] Renamed MetricAnomalyAlertConfiguration to MetricAlertConfiguration #22116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
kinelski
commented
Jun 23, 2021
maririos
reviewed
Jun 24, 2021
...etricsAdvisor/tests/MetricsAdvisorAdministrationClient/AnomalyAlertConfigurationLiveTests.cs
Outdated
Show resolved
Hide resolved
| { | ||
| public MetricAnomalyAlertConfiguration(string detectionConfigurationId, Azure.AI.MetricsAdvisor.Models.MetricAnomalyAlertScope alertScope) { } | ||
| public MetricAlertConfiguration(string detectionConfigurationId, Azure.AI.MetricsAdvisor.Models.MetricAnomalyAlertScope alertScope) { } | ||
| public Azure.AI.MetricsAdvisor.Models.MetricAnomalyAlertConditions AlertConditions { get { throw null; } set { } } |
Member
There was a problem hiding this comment.
out of curiosity, what was the reason to drop the Anomaly from it? and why it happens to only that type and not the others like this one?
Contributor
Author
There was a problem hiding this comment.
We're just aligning to what other languages are doing (.NET was the odd one out). We'll also rename MetricAnomalyAlertConditions to something else in another PR. Regarding other related models, changing them across languages is an effort with too low priority to be done in the current time frame.
...etricsAdvisor/tests/MetricsAdvisorAdministrationClient/AnomalyAlertConfigurationLiveTests.cs
Outdated
Show resolved
Hide resolved
maririos
approved these changes
Jun 24, 2021
Contributor
Author
|
/azp run net - metricsadvisor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kinelski
commented
Jun 29, 2021
|
|
||
| /// <summary> The dimension filter. </summary> | ||
| internal FeedbackDimensionFilter DimensionFilter => Filter.Dimension == null ? null : new FeedbackDimensionFilter(Filter.Dimension); | ||
| internal FeedbackDimensionFilter DimensionFilter => Filter?.Dimension == null ? null : new FeedbackDimensionFilter(Filter.Dimension); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming for cross-language consistency.