Merged
Conversation
maririos
requested review from
catalinaperalta,
kinelski,
kristapratico,
samvaity and
witemple-msft
ghost
added
the
Member
Author
|
/azp run net - formrecognizer - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
catalinaperalta
approved these changes
Jun 22, 2021
kristapratico
approved these changes
Jun 22, 2021
| Assert.AreEqual("2003", ex.ErrorCode); | ||
| Assert.True(operation.HasCompleted); | ||
| Assert.False(operation.HasValue); | ||
| Assert.AreEqual("2001", ex.ErrorCode); |
Contributor
There was a problem hiding this comment.
just wondering, did you see this change in both canary and prod?
Member
Author
There was a problem hiding this comment.
I saw it in both. Because I only run canary on the weekends, prod started failing on Friday, so idk if in the middle of the week Canary already had the changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FR team recently made deployment and fixed their error codes and the behavior across endpoints to always do parameter validation on POST and not GET operation.
This PR updates tests to reflect that.
It fixes: