[TA] Add overloads to actions #22053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maririos
requested review from
deyaaeldeen,
iscai-msft,
kinelski,
kristapratico,
mshaban-msft and
mssfang
maririos
requested review from
KrzysztofCwalina,
annelo-msft and
tg-msft
as code owners
ghost
added
the
maririos
commented
Jun 22, 2021
maririos
commented
Jun 22, 2021
| #region Analyze sentiment | ||
|
|
||
| [Test] | ||
| public async Task AnalyzeOperationAnalyzeSentimentWithDisableServiceLogs() |
Member
Author
There was a problem hiding this comment.
we didn't have mock tests for analyze sentiment, so also adding that :)
kinelski
reviewed
Jun 22, 2021
sdk/textanalytics/Azure.AI.TextAnalytics/api/Azure.AI.TextAnalytics.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/src/RecognizePiiEntitiesAction.cs
Outdated
Show resolved
Hide resolved
sdk/textanalytics/Azure.AI.TextAnalytics/api/Azure.AI.TextAnalytics.netstandard2.0.cs
Show resolved
Hide resolved
kristapratico
approved these changes
Jun 23, 2021
mssfang
approved these changes
Jun 23, 2021
maririos
added a commit
that referenced
this pull request
Jun 23, 2021
* add overloads to actions * PR feedback
maririos
added a commit
that referenced
this pull request
Jun 29, 2021
* add overloads to actions * PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last feedback from architects. Add overloads to help users go from a singular method to a analyze method.