Refactoring TelemetryPartATests.cs#22051
Merged
rajkumar-rangaraj merged 4 commits intomainfrom Jun 22, 2021
Merged
Conversation
added 3 commits
June 21, 2021 11:56
vishweshbankwar
requested review from
TimothyMothra,
cijothomas,
rajkumar-rangaraj and
reyang
as code owners
cijothomas
reviewed
Jun 22, 2021
cijothomas
reviewed
Jun 22, 2021
rajkumar-rangaraj
deleted the
vibankwa/Azure.Monitor.OTEL.Exporter/Refactor-TelemetryPartATests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving Activity creation to individual tests as this will give more control on activity creation for individual tests.
Also, CreateTestActivity() is assigning lot of properties to Activity which are not being used.