Add new Property SpotRestorePolicy to VMScaleSets #21928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepkv93
requested review from
YalinLi0312,
allenjzhang,
m-nash,
markcowl and
nisha-bhatia
as code owners
ghost
added
the
Sandido
reviewed
Jun 17, 2021
| /// <param name="extendedLocation">The extended location of the Virtual | ||
| /// Machine Scale Set.</param> | ||
| public VirtualMachineScaleSet(string location, string id = default(string), string name = default(string), string type = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), Sku sku = default(Sku), Plan plan = default(Plan), UpgradePolicy upgradePolicy = default(UpgradePolicy), AutomaticRepairsPolicy automaticRepairsPolicy = default(AutomaticRepairsPolicy), VirtualMachineScaleSetVMProfile virtualMachineProfile = default(VirtualMachineScaleSetVMProfile), string provisioningState = default(string), bool? overprovision = default(bool?), bool? doNotRunExtensionsOnOverprovisionedVMs = default(bool?), string uniqueId = default(string), bool? singlePlacementGroup = default(bool?), bool? zoneBalance = default(bool?), int? platformFaultDomainCount = default(int?), SubResource proximityPlacementGroup = default(SubResource), SubResource hostGroup = default(SubResource), AdditionalCapabilities additionalCapabilities = default(AdditionalCapabilities), ScaleInPolicy scaleInPolicy = default(ScaleInPolicy), string orchestrationMode = default(string), VirtualMachineScaleSetIdentity identity = default(VirtualMachineScaleSetIdentity), IList<string> zones = default(IList<string>), ExtendedLocation extendedLocation = default(ExtendedLocation)) | ||
| public VirtualMachineScaleSet(string location, string id = default(string), string name = default(string), string type = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), Sku sku = default(Sku), Plan plan = default(Plan), UpgradePolicy upgradePolicy = default(UpgradePolicy), AutomaticRepairsPolicy automaticRepairsPolicy = default(AutomaticRepairsPolicy), VirtualMachineScaleSetVMProfile virtualMachineProfile = default(VirtualMachineScaleSetVMProfile), string provisioningState = default(string), bool? overprovision = default(bool?), bool? doNotRunExtensionsOnOverprovisionedVMs = default(bool?), string uniqueId = default(string), bool? singlePlacementGroup = default(bool?), bool? zoneBalance = default(bool?), int? platformFaultDomainCount = default(int?), SubResource proximityPlacementGroup = default(SubResource), SubResource hostGroup = default(SubResource), AdditionalCapabilities additionalCapabilities = default(AdditionalCapabilities), ScaleInPolicy scaleInPolicy = default(ScaleInPolicy), string orchestrationMode = default(string), SpotRestorePolicy spotRestorePolicy = default(SpotRestorePolicy), VirtualMachineScaleSetIdentity identity = default(VirtualMachineScaleSetIdentity), IList<string> zones = default(IList<string>), ExtendedLocation extendedLocation = default(ExtendedLocation)) |
Contributor
There was a problem hiding this comment.
This will require a customization.
Contributor
|
The test failures in the CI checks are failing due to the API version not being updated for the Compute RP tests. |
Contributor
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Contributor
|
/azp rerun |
|
Command 'rerun' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
Contributor
|
@sandeepkv93 Could you please provide the link to the Swagger PR? |
Contributor
allenjzhang
pushed a commit
that referenced
this pull request
Jul 20, 2021
* code generation * avail * updates * RECORDINGS * new recordings * new recording * new recording * recordings * updated test because it seems like the market place offer/sku does not exist anymore then re-recorded test * Add new Property SpotRestorePolicy to VMScaleSets (#21928) * Generated Files * Tests for Spot Restore Policy * Versioning changes * Scenario Test record * customization (#22054) * update * add capacity Reservation update * customizations * fix duplicates, Capaciy Reservation for vmss * Generated SDK modules and recorded tests for Capacity Reservation and Capacity reservation in VM - API version 2021-04-01 (#22383) * updated sdk tests * updated sdk * updated sdk * udpated cpe * regenerated the sdk and re recorded the tests * updated sdk Co-authored-by: Theodore Chang <[email protected]> * Capacity Res. for Vmss (#22429) * starting changes for vmss sdk test for CR * updating vmss test base with cr items * adding vmss changes to vmss scenario test correctly * adding vmss passing test * adding tests and version updates * moving cr location in param Co-authored-by: Theodore Chang <[email protected]> * assembly version update * remove duplicate definition in tests/helpers.cs * update with CapacityReservations_Update 202 status return * sdk gen from latest swagger change * new recording for new test just added * RestorePoint test recording * code gen again to check diff * Update compute_resource-manager.txt update commit info to use latest compute swagger * added morescription to package release note. updated compute_resource-manager.txt right commit. re-generated sdk with CapacityReservationGroupInstanceViewTypes, CapacityReservationInstanceViewTypes, and ExpandTypesForGetCapacityReservationGroups changed to modelAsString true * Update AzSdk.RP.props Co-authored-by: Sandeep Vishnu <[email protected]> Co-authored-by: hari-bodicherla <[email protected]> Co-authored-by: micahjo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new servicelabel and/or contact assigned reviewer.If the check fails at the
Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.