whitespace following the Comment symbol#21636
whitespace following the Comment symbol#21636paul-cheung wants to merge 9 commits intoAzure:masterfrom
Conversation
|
Thank you for your contribution @paul-cheung! We will review the pull request and get back to you soon. |
* Batch receive fixes * Use AwaitWithCancellation * volatile * Remove unnecessary catch * Fix tests * Fix flaky tests * Fix test
|
I think you need to rebase against the tip of 'master' to fix the build errors. |
* Batch receive fixes * Use AwaitWithCancellation * volatile * Remove unnecessary catch * Fix tests * Fix flaky tests * Fix test
rebased against the tip of upstream master |
jsquire
left a comment
There was a problem hiding this comment.
It looks like your rebase introduced additional changes; I'm seeing Service Bus files changed that should not be part of this PR. Please revert or rebase (not merge) to master.
…-sdk-for-net into extraWhitespaceInComment
I have raised another one for this part of change. 21649 |
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new servicelabel and/or contact assigned reviewer.If the check fails at the
Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.