Skip to content

Resolve APIView unification comments for Key Vault#21308

Merged
heaths merged 2 commits intoAzure:masterfrom
heaths:keyvault-unification
May 24, 2021
Merged

Resolve APIView unification comments for Key Vault#21308
heaths merged 2 commits intoAzure:masterfrom
heaths:keyvault-unification

Conversation

@heaths
Copy link
Copy Markdown
Member

@heaths heaths commented May 24, 2021

No description provided.

@heaths heaths requested review from christothes and vcolin7 May 24, 2021 22:26
@heaths heaths requested a review from schaabs as a code owner May 24, 2021 22:26
@ghost ghost added the KeyVault label May 24, 2021
Copy link
Copy Markdown
Member

@vcolin7 vcolin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@heaths heaths merged commit 97e0e32 into Azure:master May 24, 2021
@heaths heaths deleted the keyvault-unification branch May 24, 2021 23:01
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Oct 27, 2022
[Hub Generated] Publish private branch 'release-trafficmanager-Microsoft.Network-2022-04-01-preview' (Azure#21308)

* Adds base for updating Microsoft.Network from version stable/2018-08-01 to version 2022-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add new property AlwaysServer for endpoints.

* Fix examples, update swagger to sdk in the readme.

* Added a new example for alwaysServe

* Use parameters like SubsId and apiVersion from common-types/v3

* Use parameter ResourceGroupNameParameter from common-types/v3

* Use ErrorDetail obj from common-types/v3 and remove CloudErrorObject.

* Revert breaking changes: Use ErrorDetail obj from common-types/v3 and remove CloudErrorObject.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants