Skip to content

[Storage] Sas version in test continued #20725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasobol-msft merged 2 commits into from
Apr 28, 2021
Merged

[Storage] Sas version in test continued #20725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29cfdec
this should work..
kasobol-msft Apr 28, 2021
3840b30
let's keep it inactive first.
kasobol-msft Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sdk/storage/Azure.Storage.Blobs.Batch/tests/Azure.Storage.Blobs.Batch.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
<Compile Include="$(AzureStorageSharedTestSources)\**\*.cs" Link="Shared\%(RecursiveDir)\%(Filename)%(Extension)" />
<Compile Remove="$(AzureStorageSharedTestSources)\AzuriteFixture.cs" />
<Compile Remove="$(AzureStorageSharedTestSources)\AzuriteNUnitFixture.cs" />
<Compile Remove="$(AzureStorageSharedTestSources)\StorageTestBase.SasVersion.cs" />
<None Include="$(AzureStorageSharedTestSources)\*.xml">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
Expand Down
32 changes: 30 additions & 2 deletions sdk/storage/Azure.Storage.Common/tests/Shared/StorageTestBase.SasVersion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

using System;
using System.Collections.Generic;
using System.Linq;
using System.Reflection;
using Azure.Core.TestFramework;
using Azure.Storage.Sas;
using NUnit.Framework;

namespace Azure.Storage.Test.Shared
Expand All @@ -17,7 +20,32 @@ public void SetSasVersion()
// WARN! Never ever override SAS version in Live mode. We should test the default there.

// TODO Uncomment this to record/playback with different sas version
// SasQueryParametersInternals.DefaultSasVersionInternal = "2020-08-04";
// SetSasVersion("2020-08-04");
}
}

private void SetSasVersion(string version)
{
// The SasQueryParametersInternals is shared source and compiled also into many assemblies which is technically separate class.
// We're using reflection to set it everywhere.
// The alternative of making it all open to all test packages isn't great because it would lead to name clash.
SetSasVersionInAssemblies(version,
"Azure.Storage.Common",
"Azure.Storage.Blobs",
"Azure.Storage.Files.DataLake",
"Azure.Storage.Files.Shares",
"Azure.Storage.Queues");
}

private void SetSasVersionInAssemblies(string version, params string[] assemblyNames)
{
IEnumerable<Assembly> assemblies = AppDomain.CurrentDomain.GetAssemblies().Where(a => assemblyNames.Contains(a.GetName().Name));
foreach (Assembly assembly in assemblies)
{
Type sasQueryParametersInternals = assembly.GetType("Azure.Storage.Sas.SasQueryParametersInternals");
PropertyInfo defaultSasVersionInternal = sasQueryParametersInternals.GetProperty(
"DefaultSasVersionInternal", BindingFlags.NonPublic | BindingFlags.Static);
defaultSasVersionInternal.SetValue(null, version);
}
}
}
Expand Down