Skip to content

update constructor signatures for autogen #20607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-nash merged 7 commits into from
Apr 23, 2021
Merged

update constructor signatures for autogen #20607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3a94beb
update constructors for reference types
m-nash Apr 16, 2021
c995b15
fix stylecop issue
m-nash Apr 19, 2021
aaf1451
add two way implicit for autorest deserialization
m-nash Apr 20, 2021
27f185e
merge from master
m-nash Apr 20, 2021
4131902
merge feature/mgmt-track2
m-nash Apr 20, 2021
e17fee6
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
m-nash Apr 23, 2021
749dfe5
update constructor signatures for autogen
m-nash Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/resourcemanager/Azure.ResourceManager.Core/src/Resources/Resource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ namespace Azure.ResourceManager.Core
/// A class representing the base resource used by all azure resources.
/// </summary>
[ReferenceType(typeof(TenantResourceIdentifier))]
public abstract class Resource<TIdentifier> : IEquatable<Resource<TIdentifier>>, IEquatable<string>,
public class Resource<TIdentifier> : IEquatable<Resource<TIdentifier>>, IEquatable<string>,
IComparable<Resource<TIdentifier>>, IComparable<string> where TIdentifier : TenantResourceIdentifier
{
/// <summary>
/// Initializes an empty instance of <see cref="Resource{TIdentifier}"/>.
/// </summary>
protected Resource() { }
public Resource() { }

/// <summary>
/// Initializes a new instance of <see cref="Resource{TIdentifier}"/> for deserialization.
Expand Down
2 changes: 1 addition & 1 deletion sdk/resourcemanager/Azure.ResourceManager.Core/src/Resources/SubResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public partial class SubResource
/// <summary>
/// Initializes an empty instance of <see cref="SubResource"/>.
/// </summary>
protected internal SubResource() { }
public SubResource() { }

/// <summary> Initializes a new instance of SubResource. </summary>
/// <param name="id"> ARM resource Id. </param>
Expand Down
8 changes: 6 additions & 2 deletions sdk/resourcemanager/Azure.ResourceManager.Core/src/Resources/TrackedResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,16 @@ namespace Azure.ResourceManager.Core
/// Generic representation of a tracked resource. All tracked resources should extend this class
/// </summary>
[ReferenceType(typeof(TenantResourceIdentifier))]
public abstract partial class TrackedResource<TIdentifier> : Resource<TIdentifier> where TIdentifier : TenantResourceIdentifier
public partial class TrackedResource<TIdentifier> : Resource<TIdentifier>
where TIdentifier : TenantResourceIdentifier
{
/// <summary>
/// Initializes an empty instance of <see cref="TrackedResource{TIdentifier}"/>.
/// </summary>
protected TrackedResource() { }
public TrackedResource(LocationData location)
{
Location = location;
}

/// <summary>
/// Initializes a new instance of the <see cref="TrackedResource{TIdentifier}"/> class for deserialization.
Expand Down