Skip to content

JonathanCrd 5574 - remove system.collections.immutable #20437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-nash merged 5 commits into from
Apr 15, 2021
Merged

JonathanCrd 5574 - remove system.collections.immutable #20437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
10f6ad0
Change the accessbility to virtual for Resource.Id
Mar 24, 2021
ccc17c7
merge from usptream
Apr 5, 2021
5060f5c
Merge branch 'feature/mgmt-track2' of https://github.com/Azure/azure-…
m-nash Apr 12, 2021
b76976d
Removing package reference to System.Collections.Immutable
JonathanCrd Apr 15, 2021
17d1f9d
Removing use of ImmutableList
JonathanCrd Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion eng/Packages.Data.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@
<PackageReference Update="System.ValueTuple" Version="4.5.0" />
<PackageReference Update="Microsoft.Bcl.AsyncInterfaces" Version="1.0.0" />
<PackageReference Update="Microsoft.CSharp" Version="4.5.0" />
<PackageReference Update="System.Collections.Immutable" Version="1.3.1" />

<!-- Azure SDK packages -->
<PackageReference Update="Azure.Core" Version="1.13.0" />
Expand Down
3 changes: 1 addition & 2 deletions sdk/resourcemanager/Azure.ResourceManager.Core/src/Adapters/WrappingPage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

using System;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.Linq;

namespace Azure.ResourceManager.Core
Expand Down Expand Up @@ -32,7 +31,7 @@ internal WrappingPage(Page<TModel> wrapped, Func<TModel, TOperations> converter)
}

/// <inheritdoc/>
public override IReadOnlyList<TOperations> Values => _wrapped.Values.Select(_converter).ToImmutableList();
public override IReadOnlyList<TOperations> Values => _wrapped.Values.Select(_converter).ToList();

/// <inheritdoc/>
public override string ContinuationToken => _wrapped.ContinuationToken;
Expand Down
1 change: 0 additions & 1 deletion sdk/resourcemanager/Azure.ResourceManager.Core/src/Azure.ResourceManager.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="System.Collections.Immutable" />
<PackageReference Include="Azure.ResourceManager.Resources" />
</ItemGroup>

Expand Down