Skip to content

Use dedicated agent pool for storage live tests#20037

Merged
benbp merged 1 commit intoAzure:masterfrom
benbp:benbp/storage-pool
Apr 12, 2021
Merged

Use dedicated agent pool for storage live tests#20037
benbp merged 1 commit intoAzure:masterfrom
benbp:benbp/storage-pool

Conversation

@benbp
Copy link
Member

@benbp benbp commented Apr 1, 2021

This PR cuts over the storage pipelines to use a dedicated storage pool that has been provisioned in Central Canada which has more memory for their specialized test scenarios.

This PR is a replacement for #19191

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Apr 1, 2021
@benbp benbp requested a review from danieljurek as a code owner April 1, 2021 19:57
@benbp benbp self-assigned this Apr 1, 2021
@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Apr 1, 2021
@benbp
Copy link
Member Author

benbp commented Apr 1, 2021

/azp run net - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp benbp force-pushed the benbp/storage-pool branch from 3a42267 to 8afb11d Compare April 1, 2021 20:18
@benbp
Copy link
Member Author

benbp commented Apr 1, 2021

/azp run net - storage - tests

@Azure Azure deleted a comment from azure-pipelines bot Apr 1, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp benbp force-pushed the benbp/storage-pool branch from 8afb11d to fd5d731 Compare April 5, 2021 16:56
@benbp
Copy link
Member Author

benbp commented Apr 5, 2021

/azp run net - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp
Copy link
Member Author

benbp commented Apr 5, 2021

/azp run net - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp benbp force-pushed the benbp/storage-pool branch from fd5d731 to c17417d Compare April 5, 2021 17:10
@benbp
Copy link
Member Author

benbp commented Apr 5, 2021

/azp run net - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. We should get confirmation from the storage team.

@weshaggard weshaggard requested a review from kasobol-msft April 12, 2021 16:27
@weshaggard
Copy link
Member

@kasobol-msft can you have a look to see if test runs look correct with these new pools?

@weshaggard
Copy link
Member

/azp run net - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard
Copy link
Member

/azp run net - storage - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kasobol-msft
Copy link
Contributor

kasobol-msft commented Apr 12, 2021

@weshaggard @benbp This doesn't look good https://dev.azure.com/azure-sdk/internal/_build/results?buildId=837569&view=ms.vss-test-web.build-test-results-tab&runId=18242910&resultId=100885&paneView=debug . I was looking at logs and it seems that agent size is correct (D4ds_v4). However .net fx tests are failing with oom which isn't the case for other .net distros. Is it possible that it runs 32 bit process ? what's the command to run net461 tests ? (the log says it's some temp psh...)

@benbp
Copy link
Member Author

benbp commented Apr 12, 2021

@kasobol-msft
Copy link
Contributor

I think I'll take that investigation outside of this PR. Either we figure out why net461 doesn't like these tests or we'll find a way to not run them on net461. #20301

@benbp
Copy link
Member Author

benbp commented Apr 12, 2021

@kasobol-msft was your intention that I should merge this and you'll address the failures, or we should keep this open?

@kasobol-msft
Copy link
Contributor

please go ahead and merge.

@benbp
Copy link
Member Author

benbp commented Apr 12, 2021

/check-enforcer override

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants