Conversation
|
Is this PR still being worked on? If it is a work in progress can you convert it to a draft PR? |
m-nash
left a comment
There was a problem hiding this comment.
Please provide the spec pr link associated with this change
| string _responseContent = null; | ||
| if ((int)_statusCode != 200) | ||
| { | ||
| var ex = new CloudException(string.Format("Operation returned an invalid status code '{0}'", _statusCode)); |
There was a problem hiding this comment.
This will result in a breaking change, please provide the corresponding spec PR. The spec PR either needs the approved-breakingchange label from the breaking change team OR we will need to find another way to do this. One option is if ErrorResponseException inherits from CloudException
There was a problem hiding this comment.
the PR link: Azure/azure-rest-api-specs#12469
This is indeed a PR with breaking changes, a new version of the swagger was introduced in the PR because of this.
Can you advise on how to get an approval for this from the breaking change team?
There was a problem hiding this comment.
On the spec PR it has a link which should get you to the right place. I have added it here for your convenience http://aka.ms/bcforapi
|
/azp run net - mgmt - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This PR has been outstanding for quite a while. Please reopen if additional info is provided. Thx |
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
new servicelabel and/or contact assigned reviewer.Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,
Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.