Skip to content

Minor tweak and comment for DtmiConventions in models repository SDK #19429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
digimaun merged 2 commits into from
Mar 10, 2021
Merged

Minor tweak and comment for DtmiConventions in models repository SDK #19429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b16d20
Covers a nit and adds comment.
digimaun Mar 10, 2021
e4c10f7
Increment changelog with date.
digimaun Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/modelsrepository/Azure.Iot.ModelsRepository/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Release History

## 1.0.0-preview.1 (Unreleased)
## 1.0.0-preview.1 (2021-03-10)

### New features

Expand Down
5 changes: 4 additions & 1 deletion sdk/modelsrepository/Azure.Iot.ModelsRepository/src/DtmiConventions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ public static Uri GetModelUri(string dtmi, Uri repositoryUri, bool expanded = fa
ModelsRepositoryConstants.ExpandedJsonFileExtension);
}

UriBuilder repositoryUriBuilder = new UriBuilder(repositoryUri);
var repositoryUriBuilder = new UriBuilder(repositoryUri);

// If the base URI (repositoryUri in this case) path segment does not end in slash
// that segment will be dropped and not properly anchored to by the intended relative URI.
if (!repositoryUriBuilder.Path.EndsWith("/", StringComparison.InvariantCultureIgnoreCase))
{
repositoryUriBuilder.Path += "/";
Expand Down