Don't append api/events to Uri#19419
Merged
JoshLove-msft merged 1 commit intoAzure:masterfrom Mar 10, 2021
Merged
Conversation
JoshLove-msft
requested review from
Kishp01,
ahamad-MS and
jfggdl
as code owners
ghost
added
the
Member
Author
|
/azp run net - eventgrid - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
@pmcilreavy we changed how the URI logic to no longer append api/events. I don't think this should impact the Event Grid simulator, but you may want to run a new test to confirm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The portal, Azure CLI, and Azure Powershell all include the api/events path in the topic URI, so there is no need to append it. Appending it could be problematic in the future if other Uri formats are expected.
Also, some cleanup of unused code.