Skip to content

Move ApiVersionOverrides to ARMClientOptions class #19358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-nash merged 1 commit into from
Mar 9, 2021
Merged

Move ApiVersionOverrides to ARMClientOptions class #19358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions sdk/resourcemanager/Azure.ResourceManager.Core/src/AzureResourceManagerClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,18 +102,11 @@ private AzureResourceManagerClient(
_baseUri = baseUri;
ClientOptions = options ?? new AzureResourceManagerClientOptions();

DefaultSubscription = string.IsNullOrWhiteSpace(defaultSubscriptionId)
DefaultSubscription = string.IsNullOrWhiteSpace(defaultSubscriptionId)
? GetDefaultSubscription()
: GetSubscriptionOperations(defaultSubscriptionId).Get().Value;

ApiVersionOverrides = new Dictionary<string, string>();
}

/// <summary>
/// Gets the Api version overrides.
/// </summary>
public virtual Dictionary<string, string> ApiVersionOverrides { get; private set; }

/// <summary>
/// Gets the default Azure subscription.
/// </summary>
Expand Down
6 changes: 6 additions & 0 deletions sdk/resourcemanager/Azure.ResourceManager.Core/src/AzureResourceManagerClientOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,14 @@ internal AzureResourceManagerClientOptions(LocationData defaultLocation, AzureRe
if (!ReferenceEquals(other, null))
Copy(other);
DefaultLocation = defaultLocation;
ApiVersionOverrides = new Dictionary<string, string>();
}

/// <summary>
/// Gets the Api version overrides.
/// </summary>
public Dictionary<string, string> ApiVersionOverrides { get; private set; }

/// <summary>
/// Gets the default location to use if can't be inherited from parent.
/// </summary>
Expand Down