API updates #19250
Merged
API updates #19250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLove-msft
requested review from
Kishp01,
KrzysztofCwalina,
ahamad-MS,
jfggdl,
pakrym and
tg-msft
as code owners
ghost
added
pakrym
reviewed
Mar 5, 2021
| get | ||
| { | ||
| return _id; | ||
| return _id!; |
Contributor
There was a problem hiding this comment.
I think we decided on throwing, no?
Member
Author
There was a problem hiding this comment.
I think the decision was to say that this could be null, if using skipValidation, i.e. if customers have nullable references enabled AND they are skipping validation, we no longer guarantee that the nullability is 100% accurate. There is no reason to throw if the customer wants to get the Id though.
Member
Author
There was a problem hiding this comment.
pakrym
reviewed
Mar 5, 2021
pakrym
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.