Time Series Insights Instances client library implementation#19209
Merged
Time Series Insights Instances client library implementation#19209
Conversation
added 14 commits
February 11, 2021 00:04
drwill-ms
reviewed
Mar 4, 2021
...riesinsights/Azure.Iot.TimeSeriesInsights/api/Azure.Iot.TimeSeriesInsights.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Mar 4, 2021
...riesinsights/Azure.Iot.TimeSeriesInsights/api/Azure.Iot.TimeSeriesInsights.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Mar 4, 2021
...seriesinsights/Azure.Iot.TimeSeriesInsights/src/Customized/Models/InstancesOperationError.cs
Show resolved
Hide resolved
bikamani
reviewed
Mar 6, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/src/TimeSeriesInsightsClient.cs
Show resolved
Hide resolved
bikamani
reviewed
Mar 6, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/src/TimeSeriesInsightsClient.cs
Outdated
Show resolved
Hide resolved
bikamani
reviewed
Mar 6, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/src/TimeSeriesInsightsClient.cs
Outdated
Show resolved
Hide resolved
bikamani
reviewed
Mar 6, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/src/TimeSeriesInsightsClient.cs
Outdated
Show resolved
Hide resolved
bikamani
reviewed
Mar 6, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/src/TimeSeriesInsightsClient.cs
Outdated
Show resolved
Hide resolved
bikamani
reviewed
Mar 6, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/src/TimeSeriesInsightsClient.cs
Outdated
Show resolved
Hide resolved
bikamani
reviewed
Mar 6, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/tests/E2eTestBase.cs
Outdated
Show resolved
Hide resolved
bikamani
reviewed
Mar 6, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/tests/E2eTestBase.cs
Show resolved
Hide resolved
bikamani
reviewed
Mar 6, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/tests/TimeSeriesIdTests.cs
Show resolved
Hide resolved
bikamani
reviewed
Mar 6, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/tests/TimeSeriesIdTests.cs
Outdated
Show resolved
Hide resolved
bikamani
reviewed
Mar 6, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/tests/TimeSeriesIdTests.cs
Outdated
Show resolved
Hide resolved
bikamani
approved these changes
Mar 6, 2021
Contributor
bikamani
left a comment
There was a problem hiding this comment.
Added few comments, looks good otherwise
drwill-ms
reviewed
Mar 6, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/src/Models/TimeSeriesId.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Mar 6, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/src/Models/TimeSeriesId.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Mar 6, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/src/Models/TimeSeriesId.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Mar 6, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/tests/E2eTestBase.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Mar 6, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/tests/TimeSeriesIdTests.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Mar 6, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/src/Models/TimeSeriesId.cs
Outdated
Show resolved
Hide resolved
drwill-ms
approved these changes
Mar 6, 2021
drwill-ms
reviewed
Mar 9, 2021
sdk/timeseriesinsights/Azure.Iot.TimeSeriesInsights/tests/TimeSeriesIdTests.cs
Outdated
Show resolved
Hide resolved
bikamani
reviewed
Mar 9, 2021
| /// <exception cref="ArgumentException"> | ||
| /// The exception is thrown when <paramref name="timeSeriesInstances"/> is empty. | ||
| /// </exception> | ||
| public virtual Response<InstancesOperationError[]> CreateOrReplaceTimeSeriesInstances( |
Contributor
There was a problem hiding this comment.
Something I just noticed now, did you intend to create a separate API for "replace" or combined for "create and replace"?
Looking at code at line: 772
Contributor
There was a problem hiding this comment.
Actually looking at swagger, I realize there is put (createOrreplace and update (just replace) - which is super confusing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some things to keep in mind before/while you are reviewing this PR: