Skip to content

nibhati-5142-add Params and testing for ApiVersionBase.cs #19193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-nash merged 2 commits into from
Mar 4, 2021
Merged

nibhati-5142-add Params and testing for ApiVersionBase.cs #19193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f6fa48
add tests for ApiVersionBase
Mar 4, 2021
b3ea730
update methods
Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions sdk/resourcemanager/Azure.ResourceManager.Core/src/ApiVersionsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ protected ApiVersionsBase(string value)
/// <returns></returns>
public static bool operator <(ApiVersionsBase left, ApiVersionsBase right)
{
if (left is null)
return true;
if (ReferenceEquals(null, left))
return !ReferenceEquals(null, right);

return left.CompareTo(right) == -1;
}
Expand All @@ -44,7 +44,7 @@ protected ApiVersionsBase(string value)
/// <returns></returns>
public static bool operator >(ApiVersionsBase left, ApiVersionsBase right)
{
if (left is null)
if (ReferenceEquals(null, left))
return false;

return left.CompareTo(right) == 1;
Expand All @@ -57,6 +57,10 @@ protected ApiVersionsBase(string value)
/// <returns> API version value. </returns>
public static implicit operator string(ApiVersionsBase version)
{
if (ReferenceEquals(null, version))
{
return null;
}
return version._value;
}

Expand Down Expand Up @@ -109,7 +113,7 @@ public static implicit operator string(ApiVersionsBase version)
/// <returns> Comparison result in integer. 1 for greater than, 0 for equals to, and -1 for less than. </returns>
public int CompareTo(string other)
{
if (other == null)
if (other is null)
{
return 1;
}
Expand Down Expand Up @@ -180,14 +184,9 @@ public override string ToString()
public override bool Equals(object obj)
{
if (obj is ApiVersionsBase)
{
return Equals(obj as ApiVersionsBase);
}

if (obj is string)
{
return Equals(obj as string);
}

return false;
}
Expand Down
40 changes: 40 additions & 0 deletions sdk/resourcemanager/Azure.ResourceManager.Core/tests/ApiVersionsBaseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ private FakeResourceApiVersions ConvertFromString(string version)
return FakeResourceApiVersions.V2019_12_01_preview_1;
case "2019-12-01-foobar":
return FakeResourceApiVersions.V2019_12_01_foobar;
case null:
return null;
default:
throw new ArgumentException($"Version ({version}) was not valid");
}
Expand Down Expand Up @@ -212,5 +214,43 @@ public void GetHashCodeTest()
FakeResourceApiVersions version = FakeResourceApiVersions.Default;
Assert.AreEqual(version.ToString().GetHashCode(), version.GetHashCode());
}

[TestCase("2019-12-01", null)]
[TestCase("2020-06-01", "2019-12-01")]
public void TestGreaterThanTrue(string leftString, string rightString)
{
FakeResourceApiVersions left = ConvertFromString(leftString);
FakeResourceApiVersions right = ConvertFromString(rightString);
Assert.IsTrue(left > right);
}

[TestCase(null, "2019-12-01")]
[TestCase("2019-12-01", "2020-06-01")]
[TestCase(null, null)]
public void TestGreaterThanFalse(string leftString, string rightString)
{
FakeResourceApiVersions left = ConvertFromString(leftString);
FakeResourceApiVersions right = ConvertFromString(rightString);
Assert.IsFalse(left > right);
}

[TestCase(null, "2019-12-01")]
[TestCase("2019-12-01-foobar", "2019-12-01-preview-1")]
public void TestLessThanTrue(string leftString, string rightString)
{
FakeResourceApiVersions left = ConvertFromString(leftString);
FakeResourceApiVersions right = ConvertFromString(rightString);
Assert.IsTrue(left < right);
}

[TestCase("2019-12-01", null)]
[TestCase("2020-06-01", "2019-12-01-foobar")]
[TestCase(null, null)]
public void TestLessThanFalse(string leftString, string rightString)
{
FakeResourceApiVersions left = ConvertFromString(leftString);
FakeResourceApiVersions right = ConvertFromString(rightString);
Assert.IsFalse(left < right);
}
}
}