Updates to enable live testing in sovereign clouds for multiple services #19160
Conversation
ghost
added
Azure.Core
Azure.Identity
App Configuration
jsquire
left a comment
jsquire
left a comment
There was a problem hiding this comment.
The Event Hubs and Service Bus bits look good to me; I have some concerns with China being very, very slow due to the management operations, but I'll monitor and adjust timeouts as needed based on the results.
| /// The URL of the Azure Authority host to be used for authentication. Recorded. | ||
| /// </summary> | ||
| public string AuthorityHostUrl => GetRecordedOptionalVariable("AZURE_AUTHORITY_HOST"); | ||
| public string AuthorityHostUrl => GetRecordedOptionalVariable("AZURE_AUTHORITY_HOST") ?? "https://login.microsoftonline.com/"; |
There was a problem hiding this comment.
If you're going to do this here, you should do the same for StorageEndpointSuffix, ResourceManagerUrl and ServiceManagementUrl.
That said, I think there was a reason why @pakrym didn't want to do that here. We should make sure that he's good with this change.
There was a problem hiding this comment.
Is the AZURE_AUTHORITY_HOST value produced by the New-TestResources? Why do we ever need to fall back?
| Response<ShareFileInfo> createResponse = await fileFromDirectoryClient.CreateAsync(Constants.KB); | ||
|
|
||
| Uri expectedUri = new Uri($"https://{TestConfigDefault.AccountName}.file.core.windows.net/{test.Share.Name}/{Uri.EscapeDataString(directoryName)}/{Uri.EscapeDataString(fileName)}"); | ||
| string endpointSuffix = Environment.GetEnvironmentVariable("STORAGE_ENDPOINT_SUFFIX") ?? Constants.ConnectionStrings.DefaultEndpointSuffix; |
There was a problem hiding this comment.
I don't think we should use env vars directly here. cc @kasobol-msft
There was a problem hiding this comment.
https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/storage/Azure.Storage.Common/tests/Shared/TestConfigurationsTemplate.xml has service endpoints. these should be used instead. And looks like that template needs work to accommodate these other clouds.
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
5 participants
We are running live Tests against other clouds like US Gov and Azure China Cloud. The goal is to check whether new azure sdk package work with other clouds or not.
Using this RR to trace and fix issues we encounter in the tests. Will close it once we finish all the tests and send PR per services.
Updated list:
Text analytics
Core
Extensions
Event hubs
Identity
key vault
Search
Storage account
Form recognizer
Service bus
Event grid
Tables