Throw on transfer options facade overflow #19119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaschrep-msft
requested review from
amishra-dev,
amnguye,
kasobol-msft,
seanmcc-msft and
tg-msft
as code owners
ghost
added
the
kasobol-msft
approved these changes
Mar 2, 2021
amnguye
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backwards compatible
int?facades on StorageTransferOptions silently ignore int overflow, producing negative length values. This change checks overflow on cast, throwing OverflowException when encountered. This brings StorageTransferOptions in line with how other int facades handle this situation.