[Communication] - Identity/TURN - Re-adding the TURN SDK (as I accidentally overwrote those commits)#19088
Merged
RezaJooyandeh merged 14 commits intoAzure:feature/communciation/turn_api_private_previewfrom Mar 1, 2021
Conversation
added 14 commits
February 19, 2021 17:44
…ic API definition file.
ghost
added
the
apattath
changed the title
RezaJooyandeh
approved these changes
Mar 1, 2021
RezaJooyandeh
merged commit 3a28635
into
Azure:feature/communciation/turn_api_private_preview
apattath
added a commit
that referenced
this pull request
Mar 10, 2021
…ntally overwrote those commits) (#19088) * generate turn sdk api from swagger * generated sdk with same preview version for both swaggers * updated sdk with new swagger that adds CommunicationTurn models * add SDK test for turn credential issue API * Update to use updated swaggers for turn and identity * Update SDK to use different clients for identity and turn endpoints. * Update API by running Export-API.ps1 script * Update samples in the SDK to include TURN API * fixing some bugs in tests. * Add recorded test requests/responses for TURN API. * Remove ToDos and update typos. * Updates after merging with latest master * Need not sanitize url and username in TURN response. Also update public API definition file. * Improve content language in ReadMe based on reviewer comments. Co-authored-by: Avin Pattath <avinp@microsoft.com>
apattath
added a commit
that referenced
this pull request
Apr 2, 2021
…ntally overwrote those commits) (#19088) * generate turn sdk api from swagger * generated sdk with same preview version for both swaggers * updated sdk with new swagger that adds CommunicationTurn models * add SDK test for turn credential issue API * Update to use updated swaggers for turn and identity * Update SDK to use different clients for identity and turn endpoints. * Update API by running Export-API.ps1 script * Update samples in the SDK to include TURN API * fixing some bugs in tests. * Add recorded test requests/responses for TURN API. * Remove ToDos and update typos. * Updates after merging with latest master * Need not sanitize url and username in TURN response. Also update public API definition file. * Improve content language in ReadMe based on reviewer comments. Co-authored-by: Avin Pattath <avinp@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Azure.Communication.Identity library with an additional API GetTurnCredentials.
This endpoint in the service is gated behind an AFEC and enabled for a preview version.
This version of the SDK is intended to be generated only in private preview at this time and released through the dev feed (not the public nuget feed). Hence, the suggestion from Wes Haggard was to submit this to a feature branch and release SDK from the feature branch into the dev feed.
Link to PR with updated swagger: Azure/azure-rest-api-specs#12881
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
new servicelabel and/or contact assigned reviewer.Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,
Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.