[Messaging Clients] Maximum Authorization Refresh#18993
Merged
jsquire merged 1 commit intoAzure:masterfrom Feb 24, 2021
Merged
Conversation
jsquire
added
Service Bus
Event Hubs
Client
jsquire
requested review from
AlexGhiondea,
JoshLove-msft,
christothes and
serkantkaraca
Member
Author
|
/azp run net - eventhub - tests |
Member
Author
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/eventhub/Azure.Messaging.EventHubs/src/Amqp/AmqpConnectionScope.cs
Outdated
Show resolved
Hide resolved
The focus of these changes is to apply a maximum duration to the time allowed before authorization is refreshed with the Event Hubs or Service Bus service. This fixes an issue where some long-lived SAS tokens were exceeding the maximum interval allowed by the refresh timer (49 days, 17 hours, and change), causing exceptions in the messaging clients.
jsquire
force-pushed
the
messaging/max-refresh
branch
from
70466bb to
83a8a01
Compare
JoshLove-msft
approved these changes
Feb 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to apply a maximum duration to the time allowed before authorization is refreshed with the Event Hubs or Service Bus service. This fixes an issue where some long-lived SAS tokens were exceeding the maximum interval allowed by the refresh timer (49 days, 17 hours, 2 minutes, 47 seconds, 294 ms) and causing exceptions in the messaging clients.
Last Upstream Rebase
Wednesday, February 24, 1:00pm (EST)
References and Related