Override BinaryData serialization in JsonObjectSerializer#18978
Merged
JoshLove-msft merged 2 commits intoAzure:masterfrom Feb 24, 2021
Merged
Override BinaryData serialization in JsonObjectSerializer#18978JoshLove-msft merged 2 commits intoAzure:masterfrom
JoshLove-msft merged 2 commits intoAzure:masterfrom
Conversation
JoshLove-msft
requested review from
KrzysztofCwalina,
pakrym and
tg-msft
as code owners
ghost
added
the
JoshLove-msft
commented
Feb 24, 2021
|
|
||
| private BinaryData SerializeToBinaryDataInternal(object? value, Type? inputType) | ||
| { | ||
| byte[] bytes = JsonSerializer.SerializeToUtf8Bytes(value, inputType ?? value?.GetType() ?? typeof(object), _options); |
Member
Author
There was a problem hiding this comment.
The jsonSerializable ctor of BinaryData actually does this, but it seems better to be explicit here in terms of the serializer being used.
pakrym
approved these changes
Feb 24, 2021
pakrym
reviewed
Feb 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #18931