Use the Traceparent from the HTTP request header#18959
Merged
JoshLove-msft merged 4 commits intoAzure:masterfrom Feb 24, 2021
Merged
Use the Traceparent from the HTTP request header#18959JoshLove-msft merged 4 commits intoAzure:masterfrom
JoshLove-msft merged 4 commits intoAzure:masterfrom
Conversation
JoshLove-msft
requested review from
Kishp01,
ahamad-MS and
jfggdl
as code owners
ghost
added
the
pakrym
reviewed
Feb 23, 2021
sdk/eventgrid/Azure.Messaging.EventGrid/src/Customization/CloudEventRequestContent.cs
Outdated
Show resolved
Hide resolved
pakrym
reviewed
Feb 23, 2021
sdk/eventgrid/Azure.Messaging.EventGrid/src/Customization/CloudEventRequestContent.cs
Show resolved
Hide resolved
pakrym
reviewed
Feb 23, 2021
sdk/eventgrid/Azure.Messaging.EventGrid/src/Customization/CloudEventRequestContent.cs
Outdated
Show resolved
Hide resolved
pakrym
reviewed
Feb 23, 2021
sdk/eventgrid/Azure.Messaging.EventGrid/src/Customization/CloudEventRequestContent.cs
Show resolved
Hide resolved
pakrym
approved these changes
Feb 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing traceparent tests still pass as the value is sanitized, though I confirmed with a manual local re-recording that the CloudEvent traceparent now matches the HTTP request traceparent.