Remote Rendering: Changed constructors to match guidance#18950
Remote Rendering: Changed constructors to match guidance#189502 commits merged intoAzure:masterfrom craigktreasure:craig/rr-ctors
Conversation
- Splitting the most common constructor (quickstart constructor) to reduce confusion for some developers according to usability studies.
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
- The Azure Review board is preferring that we flatten the constructor to remove confusion with the extra type. We've been asked to do this in another service and we don't want ARR to be different.
|
Hello @craigktreasure! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
There are essentially 2 changes here (and 2 commits):