Remove some unused code and fix flaky test#18933
Merged
JoshLove-msft merged 1 commit intoAzure:masterfrom Feb 24, 2021
Merged
Conversation
ghost
added
the
Member
Author
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsquire
approved these changes
Feb 23, 2021
| await Task.Delay(lockDuration.Add(TimeSpan.FromSeconds(10))); | ||
| // wait 3x lockduration since to avoid the case where | ||
| // lock is renewed at the very end of the lock duration delay | ||
| await Task.Delay(lockDuration.Add(lockDuration).Add(lockDuration)); |
Member
There was a problem hiding this comment.
You may want to consider simplifying here:
await Task.Delay(lockDuration.Multiply(3));
Member
Author
There was a problem hiding this comment.
This isn't available in net461
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AMQP rule manager was not exposed and is not planned to be.