[Synapse] - Many models now have public setters

[idear1203]

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

• Please open PR in Draft mode if it is:
  • Work in progress or not intended to be merged.
  • Encountering multiple pipeline failures and working on fixes.
• If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
• I have read the contribution guidelines.
• The pull request does not introduce breaking changes.

General Guidelines and Best Practices

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• Pull request includes test coverage for the included changes.

SDK Generation Guidelines

• The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
• The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

• Include updated management metadata.
• Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

• If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
• If the check fails at the Verify Code Generation step, please ensure:
  • Do not modify any code in generated folders.
  • Do not selectively include/remove generated files in the PR.
  • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
    Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

[chamons]

I think you mean settings, not getters, in both the doc and PR title?

• public string SessionId { get; }

• public string SessionId { get; set; }

Hey @pakrym - Is this the best way to do this?

[pakrym]

Why are we doing this?

[chamons]

Bah - I can't "undo" hitting approve not comment. But I meant comment ^.

[chamons]

Hey @idear1203 - I wonder if you are fighting the generator in needed to make the models public (previously) and get/set (here).

We might need to modify the autorest.csharp to better support this.

Some details on why we need this would be useful.

[idear1203]

@chamons we received feedback from SDK users, compared with the ADF SDK that they use before, there are some properties now don't have public setters. I believe this is also because these classes are generated to be internal. So for now I want to use customizations to solve the issue.

[chamons]

In theory these manual changes aren't needed, we should be able to mark the configuration that these models should be public and have setters without so much customization.

However, if we add that then we can undo the customization in the future, so no reason to block on that.