Skip to content

Updating RemoteRendering SDK to be based on latest API spec and make classes more mockable#18694

Merged
4 commits merged intoAzure:masterfrom
AleksandarTomicMs2:user/altom/update
Feb 12, 2021
Merged

Updating RemoteRendering SDK to be based on latest API spec and make classes more mockable#18694
4 commits merged intoAzure:masterfrom
AleksandarTomicMs2:user/altom/update

Conversation

@AleksandarTomicMs2
Copy link
Copy Markdown
Member

This PR regenerated the SDK based on minor API changes (Azure/azure-rest-api-specs#12920) and makes the classes more mockable.

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • [] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
  • If the check fails at the Verify Code Generation step, please ensure:
    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@AlexGhiondea AlexGhiondea requested a review from pakrym February 11, 2021 21:25
@AleksandarTomicMs2
Copy link
Copy Markdown
Member Author

/azp run net - mixedreality - ci

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 18694 in repo Azure/azure-sdk-for-net

@matyrr-havok
Copy link
Copy Markdown
Member

/azp run net - mixedreality - ci

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link
Copy Markdown

ghost commented Feb 12, 2021

Hello @MalcolmTyrrell!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 8f2c869 into Azure:master Feb 12, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants