Updating RemoteRendering SDK to be based on latest API spec and make classes more mockable#18694
Merged
4 commits merged intoAzure:masterfrom Feb 12, 2021
Merged
Conversation
matyrr-havok
approved these changes
Feb 11, 2021
pakrym
reviewed
Feb 11, 2021
.../Azure.MixedReality.RemoteRendering/src/Customizations/Models/RemoteRenderingModelFactory.cs
Outdated
Show resolved
Hide resolved
pakrym
approved these changes
Feb 11, 2021
Member
Author
|
/azp run net - mixedreality - ci |
|
Commenter does not have sufficient privileges for PR 18694 in repo Azure/azure-sdk-for-net |
Member
|
/azp run net - mixedreality - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hello @MalcolmTyrrell! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR regenerated the SDK based on minor API changes (Azure/azure-rest-api-specs#12920) and makes the classes more mockable.
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
new servicelabel and/or contact assigned reviewer.Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,
Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.