ImdsManagedIdentitySource handles 502 response with CredentialUnavailableException#18479
Merged
christothes merged 3 commits intoAzure:masterfrom Feb 23, 2021
Merged
Conversation
ghost
added
the
schaabs
reviewed
Feb 23, 2021
|
|
||
| var options = new TokenCredentialOptions() { Transport = mockTransport }; | ||
|
|
||
| options.Retry.MaxRetries = 0; |
There was a problem hiding this comment.
Do we still want to retry on 502 or should it be excluded in the response classifier for the ManagedIdentityCredential? I'm ok with still retrying if we think that's the right thing to do here, but I want to make sure it's an explicit choice.
schaabs
reviewed
Feb 23, 2021
|
|
||
| [NonParallelizable] | ||
| [Test] | ||
| public async Task VerifyAppService2017RequestMockAsync() |
Member
Author
There was a problem hiding this comment.
Yes, dupe of VerifyAppService2017RequestWithClientIdMockAsync
There was a problem hiding this comment.
It looks like VerifyAppService2017RequestWithClientIdMockAsync always requests a user assigned id. I think we should test with this parameter an without. Perhaps we can add a parameter to VerifyAppService2017RequestWithClientIdMockAsync so we can test with a clientId and with specifying null for the clientId?
schaabs
approved these changes
Feb 23, 2021
ghost
reviewed
Feb 23, 2021
schaabs
approved these changes
Feb 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #18362