Skip to content

Update Cosmos DB Management to 01-15 #18454

Merged
allenjzhang merged 15 commits intoAzure:masterfrom
kristynhamasaki:0115Stable
Feb 18, 2021
Merged

Update Cosmos DB Management to 01-15 #18454
allenjzhang merged 15 commits intoAzure:masterfrom
kristynhamasaki:0115Stable

Conversation

@kristynhamasaki
Copy link
Copy Markdown
Contributor

@kristynhamasaki kristynhamasaki commented Feb 4, 2021

All SDK Contribution checklist:

Based on this Swagger spec version 01-15 Azure/azure-rest-api-specs#12261

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
  • If the check fails at the Verify Code Generation step, please ensure:
    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@check-enforcer
Copy link
Copy Markdown

check-enforcer bot commented Feb 4, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@kristynhamasaki kristynhamasaki changed the title WIP Update Cosmos DB Managemenet to 01-15 Update Cosmos DB Managemenet to 01-15 Feb 10, 2021
@kristynhamasaki kristynhamasaki marked this pull request as ready for review February 10, 2021 00:47
@kristynhamasaki kristynhamasaki changed the title Update Cosmos DB Managemenet to 01-15 Update Cosmos DB Management to 01-15 Feb 11, 2021
@kristynhamasaki kristynhamasaki force-pushed the 0115Stable branch 2 times, most recently from e5ab141 to d2ac0d9 Compare February 11, 2021 01:25
@kristynhamasaki
Copy link
Copy Markdown
Contributor Author

Hi @allenjzhang Please take a look at this PR when you have the chance!

It is just failing the build check with "Discrepancy detected between generated code in PR and reference generation." in one file: Generated/Models/BackupPolicy.cs where my version has Newtonsoft.Json but the pipeline's version doesn't. I generated the code using generate.ps1 but I am still seeing this difference. Please let me know if I should manually make the change to the file to pass the check. Thanks!

@allenjzhang
Copy link
Copy Markdown
Contributor

/azp run net - mgmt - ci

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@allenjzhang allenjzhang merged commit 71c0afb into Azure:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants