Failed the pipeline once there is error reported #18154
Conversation
sima-zhu
requested review from
chidozieononiwu,
danieljurek,
mitchdenny and
weshaggard
as code owners
| displayName: 'Run CredScan' | ||
| inputs: | ||
| suppressionsFile: 'eng\CredScanSuppression.json' | ||
| - task: securedevelopmentteam.vss-secure-development-tools.build-task-publishsecurityanalysislogs.PublishSecurityAnalysisLogs@3 |
There was a problem hiding this comment.
Why would you publish before the a analysis?
There was a problem hiding this comment.
I am thinking to fail the post analysis if new issues coming. Then the publish step needs to either put before post analysis or run under condition of successOrFailed. Both two do not make too much difference, so I rearrange the order which is not blocking the publish step.
There was a problem hiding this comment.
That's fair. I agree it doesn't matter for our cases the order just seemed a little odd.
jsquire
added
the
no-recent-activity
|
Hi @sima-zhu. There hasn't been recent engagement on this PR. Would you please be so kind as to let us know if this is still an active work stream by removing the no-recent-activity label? Otherwise, we'll close this out in 7 days. |
|
@jsquire Thanks for reminding! Closed the PR |
3 participants
It is currently only throwing a warning to pipeline when it detect new credential. Make changes so that it can fail the pipeline.