Skip to content

Update Track1CodeCheck.ps1 for parsing and output #18073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allenjzhang merged 3 commits into from
Jan 21, 2021
Merged

Update Track1CodeCheck.ps1 for parsing and output #18073

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db1ea83
Update Track1CodeCheck.ps1
HarveyLink Jan 20, 2021
8883324
Update Track1CodeCheck.ps1
HarveyLink Jan 20, 2021
ee1cb0e
Update Track1CodeCheck.ps1
HarveyLink Jan 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions eng/scripts/Track1CodeCheck.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ try {
}
$changeList | ForEach-Object {
$fileName = $_.filename
if ($fileName -match 'sdk/') {
if ($fileName -match 'sdk/' -and $fileName -match '/Microsoft.Azure.Management') {
$name = $fileName.substring(4, (($fileName.indexof('/Microsoft') - 4)))
If ($folderName -notcontains $name) {
$folderName += $name
Expand Down Expand Up @@ -211,7 +211,11 @@ try {
$diffResult | ForEach-Object {
Write-Output $_
}
LogError "Generated code is manually altered, you may need to re-run sdk\<RP_Name>\generate.ps1"
LogError "============================"
LogError "Discrepancy detected between generated code in PR and reference generation. Please note, the files in the Generated folder should not be modified OR adding/excluding files. You may need to re-run sdk<RP_Name>\generate.ps1."
LogError "============================"
Write-Host "For reference, we are using this command for the code check: " -ForegroundColor red -BackgroundColor white
Write-Host " autorest https://github.com/<Repo_Name>/azure-rest-api-specs/blob/<Commit_Id>/specification/<RP_Name>/resource-manager/readme.md --csharp --version=v2 --reflect-api-versions --csharp-sdks-folder=<SDK_Repo_Path>/sdk --use:@microsoft.azure/[email protected]" -ForegroundColor red -BackgroundColor white
}
}
finally {
Expand Down